[
https://issues.apache.org/jira/browse/DISPATCH-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273958#comment-17273958
]
ASF GitHub Bot commented on DISPATCH-1870:
------------------------------------------
fgiorgetti commented on pull request #944:
URL: https://github.com/apache/qpid-dispatch/pull/944#issuecomment-769332331
Fixed as well. Thanks!
On Thu, Jan 28, 2021 at 3:05 PM Jiri Daněk <notificati...@github.com> wrote:
> *@jiridanek* commented on this pull request.
> ------------------------------
>
> In tests/friendship_server.py
> <https://github.com/apache/qpid-dispatch/pull/944#discussion_r566301249>:
>
> > + p2 = self.get_person(fr.email2)
>
> + if None in [res.friend1, res.friend2]:
>
> + res.error = "Invalid email provided"
>
> + else:
>
> + if fr.email2 not in p1.friends:
>
> + p1.friends.append(fr.email2)
>
> + if fr.email1 not in p2.friends:
>
> + p2.friends.append(fr.email1)
>
> + res.friend1.CopyFrom(p1)
>
> + res.friend2.CopyFrom(p2)
>
> + except Exception as e:
>
> + res.error = e.__str__()
>
> + finally:
>
> + yield res
>
> +
>
> + def get_person(self, email) -> Person:
>
>
> One more change needed for Python 2 types,
> https://mypy.readthedocs.io/en/stable/python2.html
> ⬇️ Suggested change
>
> - def get_person(self, email) -> Person:
>
> + def get_person(self, email):
>
> + # type: (str) -> Person
>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/qpid-dispatch/pull/944#pullrequestreview-578604699>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/ABYML4VY33HY7ECPI6EAPNDS4GROJANCNFSM4UXNSQLQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add new system test to validate gRPC through HTTP2 adaptors
> -----------------------------------------------------------
>
> Key: DISPATCH-1870
> URL: https://issues.apache.org/jira/browse/DISPATCH-1870
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
> Affects Versions: 1.15.0
> Reporter: Fernando Giorgetti
> Assignee: Fernando Giorgetti
> Priority: Major
> Fix For: 1.15.0
>
>
> Implement a new system test to validate gRPC through the router HTTP2
> adaptors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
