jiridanek commented on a change in pull request #1006:
URL: https://github.com/apache/qpid-dispatch/pull/1006#discussion_r566853408
##########
File path: CMakeLists.txt
##########
@@ -65,6 +65,8 @@ message(STATUS "Found Proton: ${Proton_LIBRARIES} (found
version \"${Proton_VERS
# http2 support is optional
find_package(libnghttp2 1.4.0)
+CMAKE_DEPENDENT_OPTION(USE_LIBNGHTTP2 "Use libnghttp2 for HTTP/2 support" ON
+ "libnghttp2_FOUND" OFF)
Review comment:
@ganeshmurthy I think this is worthwhile change. It is the same pattern
that is used for libwebsockets defined below this.
The name of the variable could be better, maybe? Something like
`QD_USE_LIBNGHTTP2` or maybe `QD_ENABLE_HTTP2`? But then i'd have to rename the
other one too, and would have to create alias for backwards compatibility....
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
