jiridanek commented on a change in pull request #1006:
URL: https://github.com/apache/qpid-dispatch/pull/1006#discussion_r566865772
##########
File path: CMakeLists.txt
##########
@@ -65,6 +65,8 @@ message(STATUS "Found Proton: ${Proton_LIBRARIES} (found
version \"${Proton_VERS
# http2 support is optional
find_package(libnghttp2 1.4.0)
+CMAKE_DEPENDENT_OPTION(USE_LIBNGHTTP2 "Use libnghttp2 for HTTP/2 support" ON
+ "libnghttp2_FOUND" OFF)
Review comment:
It is the same pattern that is used for libwebsockets defined below
this. It is not needed, but I think that Alan did nice work about CMake
definitions for libwebsockets.
The reason for not using `libnghttp2_FOUND` everywhere in the CMakeLists.txt
is that "the decision to use the library in compiling dispatch does not only
depend on whether the library is present, but the user should also have the
option to choose whether the library should be used".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
