[
https://issues.apache.org/jira/browse/DISPATCH-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17274476#comment-17274476
]
ASF GitHub Bot commented on DISPATCH-1870:
------------------------------------------
ganeshmurthy commented on a change in pull request #1006:
URL: https://github.com/apache/qpid-dispatch/pull/1006#discussion_r566863313
##########
File path: CMakeLists.txt
##########
@@ -65,6 +65,8 @@ message(STATUS "Found Proton: ${Proton_LIBRARIES} (found
version \"${Proton_VERS
# http2 support is optional
find_package(libnghttp2 1.4.0)
+CMAKE_DEPENDENT_OPTION(USE_LIBNGHTTP2 "Use libnghttp2 for HTTP/2 support" ON
+ "libnghttp2_FOUND" OFF)
Review comment:
Can you please elaborate on why this change is needed ? And if we are
going to do this, I prefer we tackle it in a new JIRA which talks about adding
USE_LIBNGHTTP2. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add new system test to validate gRPC through HTTP2 adaptors
> -----------------------------------------------------------
>
> Key: DISPATCH-1870
> URL: https://issues.apache.org/jira/browse/DISPATCH-1870
> Project: Qpid Dispatch
> Issue Type: Test
> Components: Tests
> Affects Versions: 1.15.0
> Reporter: Fernando Giorgetti
> Assignee: Fernando Giorgetti
> Priority: Major
> Fix For: 1.15.0
>
>
> Implement a new system test to validate gRPC through the router HTTP2
> adaptors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
