[
https://issues.apache.org/jira/browse/DISPATCH-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283946#comment-17283946
]
ASF GitHub Bot commented on DISPATCH-1960:
------------------------------------------
kgiusti commented on a change in pull request #1027:
URL: https://github.com/apache/qpid-dispatch/pull/1027#discussion_r575484508
##########
File path: include/qpid/dispatch/alloc_pool.h
##########
@@ -80,7 +80,26 @@ void *qd_alloc(qd_alloc_type_desc_t *desc, qd_alloc_pool_t
**tpool);
/** De-allocate from a thread pool. Use via ALLOC_DECLARE */
void qd_dealloc(qd_alloc_type_desc_t *desc, qd_alloc_pool_t **tpool, char *p);
uint32_t qd_alloc_sequence(void *p);
-static inline void qd_nullify_safe_ptr(qd_alloc_safe_ptr_t *sp) { sp->ptr = 0;
}
+
+// generic safe pointer api for any alloc pool item
+
+#define QD_SAFE_PTR_INIT(p) { .ptr = (void*)(p), .seq = qd_alloc_sequence(p) }
+
+static inline void qd_nullify_safe_ptr(qd_alloc_safe_ptr_t *sp)
Review comment:
I think qd_nullify.. is used in other places outside of Q2. A change
like that probably deserves a separate patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Re-factor Q2 flow logic to allow adaptors to support Q2
> -------------------------------------------------------
>
> Key: DISPATCH-1960
> URL: https://issues.apache.org/jira/browse/DISPATCH-1960
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Router Node
> Affects Versions: 1.15.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
> Fix For: 1.16.0
>
>
> Q2 is currently hard-wired to proton AMQP links, which makes sense since no
> other type of link existed when Q2 was designed/implemented.
> In 1.15.0 protocol bridge support was included for non proton/AMQP links via
> protocol adaptors.
> These adaptors need to honor Q2 flow control. This entails having any
> protocol adaptor (or AMQP link) restart a corresponding incoming link that
> may be using a different protocol from the outgoing (Q2 relieving) link.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
