[
https://issues.apache.org/jira/browse/DISPATCH-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283949#comment-17283949
]
ASF GitHub Bot commented on DISPATCH-1960:
------------------------------------------
kgiusti commented on a change in pull request #1027:
URL: https://github.com/apache/qpid-dispatch/pull/1027#discussion_r575488021
##########
File path: src/message.c
##########
@@ -2891,3 +2911,21 @@ int qd_message_stream_data_append(qd_message_t *message,
qd_buffer_list_t *data)
qd_compose_free(field);
return rc;
}
+
+
+void qd_message_set_Q2_unblocked_handler(qd_message_t *msg,
+ qd_message_Q2_unblocked_handler_t
callback,
+ const qd_alloc_safe_ptr_t *ptr)
Review comment:
Yeah, I've refactored this a bit. I'm not crazy about passing in an
actual pointer as the context and having the callback also take a pointer.
This API would infer that the pointer passed in is handed back, which it isn't.
I want to avoid a pointer here because that raises ownership issues,
possibly cross threads. I chose instead a pass by value API so it's clear that
ownership of the safe pointer is not transferred but copied.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Re-factor Q2 flow logic to allow adaptors to support Q2
> -------------------------------------------------------
>
> Key: DISPATCH-1960
> URL: https://issues.apache.org/jira/browse/DISPATCH-1960
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Router Node
> Affects Versions: 1.15.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
> Fix For: 1.16.0
>
>
> Q2 is currently hard-wired to proton AMQP links, which makes sense since no
> other type of link existed when Q2 was designed/implemented.
> In 1.15.0 protocol bridge support was included for non proton/AMQP links via
> protocol adaptors.
> These adaptors need to honor Q2 flow control. This entails having any
> protocol adaptor (or AMQP link) restart a corresponding incoming link that
> may be using a different protocol from the outgoing (Q2 relieving) link.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
