[
https://issues.apache.org/jira/browse/DISPATCH-1960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17283948#comment-17283948
]
ASF GitHub Bot commented on DISPATCH-1960:
------------------------------------------
kgiusti commented on a change in pull request #1027:
URL: https://github.com/apache/qpid-dispatch/pull/1027#discussion_r575485738
##########
File path: include/qpid/dispatch/message.h
##########
@@ -556,12 +555,21 @@ bool qd_message_Q2_holdoff_should_unblock(qd_message_t
*msg);
*/
bool qd_message_is_Q2_blocked(const qd_message_t *msg);
Review comment:
Yeah that's a mess. Uppercase "Q2" in a function name violates our code
conventions. I'll update the patch moving all the new names to lower case for
consistency. We can change the older names in a follow up patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Re-factor Q2 flow logic to allow adaptors to support Q2
> -------------------------------------------------------
>
> Key: DISPATCH-1960
> URL: https://issues.apache.org/jira/browse/DISPATCH-1960
> Project: Qpid Dispatch
> Issue Type: Task
> Components: Router Node
> Affects Versions: 1.15.0
> Reporter: Ken Giusti
> Assignee: Ken Giusti
> Priority: Major
> Fix For: 1.16.0
>
>
> Q2 is currently hard-wired to proton AMQP links, which makes sense since no
> other type of link existed when Q2 was designed/implemented.
> In 1.15.0 protocol bridge support was included for non proton/AMQP links via
> protocol adaptors.
> These adaptors need to honor Q2 flow control. This entails having any
> protocol adaptor (or AMQP link) restart a corresponding incoming link that
> may be using a different protocol from the outgoing (Q2 relieving) link.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
