jiridanek commented on a change in pull request #1032:
URL: https://github.com/apache/qpid-dispatch/pull/1032#discussion_r576076081
##########
File path: src/router_core/modules/mobile_sync/mobile.c
##########
@@ -934,11 +934,13 @@ static void qcm_mobile_sync_final_CT(void *module_context)
{
qdrm_mobile_sync_t *msync = (qdrm_mobile_sync_t*) module_context;
+ qdr_core_unsubscribe(msync->message_sub1);
+ qdr_core_unsubscribe(msync->message_sub2);
Review comment:
```
72: Direct leak of 56 byte(s) in 1 object(s) allocated from:
72: #0 0x7f2f3dec0e8f in __interceptor_malloc
(/nix/store/g40sl3zh3nv52vj0mrl4iki5iphh5ika-gcc-10.2.0-lib/lib/libasan.so.6+0xace8f)
72: #1 0x7f2f3d61ebe8 in qd_malloc ../include/qpid/dispatch/ctools.h:229
72: #2 0x7f2f3d61f8c7 in qdr_core_subscribe
../src/router_core/route_tables.c:149
72: #3 0x7f2f3d689657 in qcm_mobile_sync_init_CT
../src/router_core/modules/mobile_sync/mobile.c:919
72: #4 0x7f2f3d61bc6f in qdr_modules_init
../src/router_core/router_core_thread.c:120
72: #5 0x7f2f3d5fbae7 in qdr_core_setup_init
../src/router_core/router_core.c:60
72: #6 0x7f2f3d5fcae9 in qdr_core ../src/router_core/router_core.c:116
72: #7 0x7f2f3d69ad1e in qd_router_setup_late ../src/router_node.c:2072
72: #8 0x7f2f3825aabc in ffi_call_unix64
(/nix/store/m8y5mz1f0al3rg3b56rq5bza49jjxnc0-libffi-3.3/lib/libffi.so.7+0x7abc)
72: #9 0x7ffec59223ef ([stack]+0x1f3ef)
72:
72: Direct leak of 56 byte(s) in 1 object(s) allocated from:
72: #0 0x7f2f3dec0e8f in __interceptor_malloc
(/nix/store/g40sl3zh3nv52vj0mrl4iki5iphh5ika-gcc-10.2.0-lib/lib/libasan.so.6+0xace8f)
72: #1 0x7f2f3d61ebe8 in qd_malloc ../include/qpid/dispatch/ctools.h:229
72: #2 0x7f2f3d61f8c7 in qdr_core_subscribe
../src/router_core/route_tables.c:149
72: #3 0x7f2f3d689705 in qcm_mobile_sync_init_CT
../src/router_core/modules/mobile_sync/mobile.c:921
72: #4 0x7f2f3d61bc6f in qdr_modules_init
../src/router_core/router_core_thread.c:120
72: #5 0x7f2f3d5fbae7 in qdr_core_setup_init
../src/router_core/router_core.c:60
72: #6 0x7f2f3d5fcae9 in qdr_core ../src/router_core/router_core.c:116
72: #7 0x7f2f3d69ad1e in qd_router_setup_late ../src/router_node.c:2072
72: #8 0x7f2f3825aabc in ffi_call_unix64
(/nix/store/m8y5mz1f0al3rg3b56rq5bza49jjxnc0-libffi-3.3/lib/libffi.so.7+0x7abc)
72: #9 0x7ffec59223ef ([stack]+0x1f3ef)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
