jiridanek commented on a change in pull request #1032:
URL: https://github.com/apache/qpid-dispatch/pull/1032#discussion_r576933871
##########
File path: src/router_pynode.c
##########
@@ -452,11 +456,17 @@ qd_error_t qd_router_python_setup(qd_router_t *router)
pySetMobileSeq = PyObject_GetAttrString(pyRouter, "setMobileSeq");
QD_ERROR_PY_RET();
pySetMyMobileSeq = PyObject_GetAttrString(pyRouter, "setMyMobileSeq");
QD_ERROR_PY_RET();
pyLinkLost = PyObject_GetAttrString(pyRouter, "linkLost");
QD_ERROR_PY_RET();
+// Py_DECREF(adapterInstance); // TODO: why not this? get python
exceptions if I try
Review comment:
I understand now. `PyTuple_SetItem` does not incref, it transfers
ownership from local context into the tuple. Meaning that doing decref here (or
for the other tuple items before) is a mistake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
