jiridanek commented on a change in pull request #1048:
URL: https://github.com/apache/qpid-dispatch/pull/1048#discussion_r581281555
##########
File path: cmake/RuntimeChecks.cmake
##########
@@ -106,9 +106,17 @@ elseif(RUNTIME_CHECK STREQUAL "asan")
message(FATAL_ERROR "libubsan not installed - address sanitizer not
available")
endif(UBSAN_LIBRARY-NOTFOUND)
message(STATUS "Runtime memory checker: gcc/clang address sanitizers")
+ option(SANITIZE_3RD_PARTY "Detect leaks in 3rd party libraries used by
Dispatch while running tests" OFF)
+ file (COPY "${CMAKE_SOURCE_DIR}/tests/lsan.supp" DESTINATION
"${CMAKE_BINARY_DIR}/tests")
+ if (NOT SANITIZE_3RD_PARTY)
Review comment:
There used to be python, libwebsockets and proton in the .so ignores.
Proton is I'd say 2nd party and it is not supposed to leak, so the so should
not be suppressed wholesale. The libwebsockets ignore will be unnecessary, so I
pulled it out into the lsan.supp directly and I have a plan to fix the leak
there. Now only Python remains.
I think I prefer having an option with a generic name. imagine if there were
any leaks in cyrus sasl or openssl, those would go under this option. It is
possible that by fixing other suppressions, something like this will crop up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
