ganeshmurthy commented on a change in pull request #1048:
URL: https://github.com/apache/qpid-dispatch/pull/1048#discussion_r581301934
##########
File path: cmake/RuntimeChecks.cmake
##########
@@ -106,9 +106,17 @@ elseif(RUNTIME_CHECK STREQUAL "asan")
message(FATAL_ERROR "libubsan not installed - address sanitizer not
available")
endif(UBSAN_LIBRARY-NOTFOUND)
message(STATUS "Runtime memory checker: gcc/clang address sanitizers")
+ option(SANITIZE_3RD_PARTY "Detect leaks in 3rd party libraries used by
Dispatch while running tests" OFF)
+ file (COPY "${CMAKE_SOURCE_DIR}/tests/lsan.supp" DESTINATION
"${CMAKE_BINARY_DIR}/tests")
Review comment:
Good point about not having generated files outside of CMAKE_BINARY_DIR.
I remember following that rule when working in Java projects using Maven. We
don't seem to follow that rule here which I have not questioned so far.
And, yes, I was talking about using the configure_file in cmake.
But you should wait on this to see what @kgiusti 's take on this is. Thx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
