[
https://issues.apache.org/jira/browse/PROTON-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312714#comment-17312714
]
Jiri Daněk commented on PROTON-2355:
------------------------------------
I'm no CMake ninja myself, but I think that spending time on trying to make the
CMake build readable is worth it, precisely because almost no one ever is a
CMake ninja.
Anyways, your patch does not work for the case when -DPROACTOR is not specified
and the build defaults to epoll:
https://github.com/jiridanek/qpid-proton/runs/2240854715#step:11:257. The
${qpid-proton-proactor} variable is undefined in cpp/CMakeLists.txt (but the
target of the same name is defined.
I'll try to fix it; I am thinking either the generator expressions I mentioned
before, or possibly define empty proactor targets when PROACTOR=none.
> Build failure with -DPROACTOR=none
> ----------------------------------
>
> Key: PROTON-2355
> URL: https://issues.apache.org/jira/browse/PROTON-2355
> Project: Qpid Proton
> Issue Type: Bug
> Components: build
> Affects Versions: proton-c-0.33.0
> Reporter: Fabrice Fontaine
> Priority: Major
> Fix For: proton-c-0.34.0
>
> Attachments: 0001-Fix-build-with-DPROACTOR-none.patch
>
>
> Building with -DPROACTOR=none fails on:
> {code:java}
> CMake Error at c/CMakeLists.txt:481 (add_library):
> Error evaluating generator expression:
> $<TARGET_OBJECTS:qpid-proton-proactor-objects>
> Objects of target "qpid-proton-proactor-objects" referenced but no such
> target exists.
> {code}
> It should also be noted that libqpid-proton-cpp also assumes that a proactor
> is always available (e.g. pn_connection_wake is unconditionally used in
> ./cpp/src/connection.cpp).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
