[
https://issues.apache.org/jira/browse/PROTON-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312901#comment-17312901
]
ASF GitHub Bot commented on PROTON-2355:
----------------------------------------
jiridanek commented on a change in pull request #302:
URL: https://github.com/apache/qpid-proton/pull/302#discussion_r605404345
##########
File path: c/CMakeLists.txt
##########
@@ -464,7 +464,11 @@ set(qpid-proton-noncore-src
${qpid-proton-include-extra}
)
-add_library (qpid-proton SHARED $<TARGET_OBJECTS:qpid-proton-core-objects>
$<TARGET_OBJECTS:qpid-proton-platform-io-objects>
$<TARGET_OBJECTS:qpid-proton-proactor-objects> ${qpid-proton-noncore-src})
+add_library (qpid-proton SHARED
+ $<TARGET_OBJECTS:qpid-proton-core-objects>
+ $<TARGET_OBJECTS:qpid-proton-platform-io-objects>
+ $<$<BOOL:${HAS_PROACTOR}>:$<TARGET_OBJECTS:qpid-proton-proactor-objects>>
Review comment:
I considered that, but then I thought that `HAS_PROACTOR` is more
directly derived from what options the user specified, whereas
`$<TARGET_EXISTS` is a check for whatever the build ended up doing. So I felt
that HAS_PROACTOR is safer.
I'll change it to TARGET_EXISTS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Build failure with -DPROACTOR=none
> ----------------------------------
>
> Key: PROTON-2355
> URL: https://issues.apache.org/jira/browse/PROTON-2355
> Project: Qpid Proton
> Issue Type: Bug
> Components: build
> Affects Versions: proton-c-0.33.0
> Reporter: Fabrice Fontaine
> Priority: Major
> Fix For: proton-c-0.34.0
>
> Attachments: 0001-Fix-build-with-DPROACTOR-none.patch
>
>
> Building with -DPROACTOR=none fails on:
> {code:java}
> CMake Error at c/CMakeLists.txt:481 (add_library):
> Error evaluating generator expression:
> $<TARGET_OBJECTS:qpid-proton-proactor-objects>
> Objects of target "qpid-proton-proactor-objects" referenced but no such
> target exists.
> {code}
> It should also be noted that libqpid-proton-cpp also assumes that a proactor
> is always available (e.g. pn_connection_wake is unconditionally used in
> ./cpp/src/connection.cpp).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
