[
https://issues.apache.org/jira/browse/PROTON-2355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312943#comment-17312943
]
ASF GitHub Bot commented on PROTON-2355:
----------------------------------------
codecov-io commented on pull request #302:
URL: https://github.com/apache/qpid-proton/pull/302#issuecomment-811704931
# [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/302?src=pr&el=h1)
Report
> Merging
[#302](https://codecov.io/gh/apache/qpid-proton/pull/302?src=pr&el=desc)
(3a23b4e) into
[main](https://codecov.io/gh/apache/qpid-proton/commit/5d3473dd484090590863c0d87dea4ea91bba87dc?el=desc)
(5d3473d) will **increase** coverage by `15.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/qpid-proton/pull/302?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## main #302 +/- ##
===========================================
+ Coverage 69.04% 84.12% +15.08%
===========================================
Files 353 47 -306
Lines 69480 2394 -67086
===========================================
- Hits 47973 2014 -45959
+ Misses 21507 380 -21127
```
| [Impacted
Files](https://codecov.io/gh/apache/qpid-proton/pull/302?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[ruby/lib/core/message.rb](https://codecov.io/gh/apache/qpid-proton/pull/302/diff?src=pr&el=tree#diff-cnVieS9saWIvY29yZS9tZXNzYWdlLnJi)
| `57.05% <0.00%> (-31.77%)` | :arrow_down: |
|
[ruby/lib/util/error\_handler.rb](https://codecov.io/gh/apache/qpid-proton/pull/302/diff?src=pr&el=tree#diff-cnVieS9saWIvdXRpbC9lcnJvcl9oYW5kbGVyLnJi)
| `59.37% <0.00%> (-28.13%)` | :arrow_down: |
|
[ruby/lib/codec/data.rb](https://codecov.io/gh/apache/qpid-proton/pull/302/diff?src=pr&el=tree#diff-cnVieS9saWIvY29kZWMvZGF0YS5yYg==)
| `81.73% <0.00%> (-14.35%)` | :arrow_down: |
|
[ruby/spec/spec\_helper.rb](https://codecov.io/gh/apache/qpid-proton/pull/302/diff?src=pr&el=tree#diff-cnVieS9zcGVjL3NwZWNfaGVscGVyLnJi)
| `54.71% <0.00%> (-9.44%)` | :arrow_down: |
|
[c/examples/raw\_echo.c](https://codecov.io/gh/apache/qpid-proton/pull/302/diff?src=pr&el=tree#diff-Yy9leGFtcGxlcy9yYXdfZWNoby5j)
| | |
|
[cpp/src/types\_internal.hpp](https://codecov.io/gh/apache/qpid-proton/pull/302/diff?src=pr&el=tree#diff-Y3BwL3NyYy90eXBlc19pbnRlcm5hbC5ocHA=)
| | |
|
[cpp/src/link\_namer.cpp](https://codecov.io/gh/apache/qpid-proton/pull/302/diff?src=pr&el=tree#diff-Y3BwL3NyYy9saW5rX25hbWVyLmNwcA==)
| | |
|
[c/tests/pn\_test\_proactor.cpp](https://codecov.io/gh/apache/qpid-proton/pull/302/diff?src=pr&el=tree#diff-Yy90ZXN0cy9wbl90ZXN0X3Byb2FjdG9yLmNwcA==)
| | |
|
[c/src/core/init.c](https://codecov.io/gh/apache/qpid-proton/pull/302/diff?src=pr&el=tree#diff-Yy9zcmMvY29yZS9pbml0LmM=)
| | |
|
[cpp/src/scalar\_test.hpp](https://codecov.io/gh/apache/qpid-proton/pull/302/diff?src=pr&el=tree#diff-Y3BwL3NyYy9zY2FsYXJfdGVzdC5ocHA=)
| | |
| ... and [300
more](https://codecov.io/gh/apache/qpid-proton/pull/302/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/qpid-proton/pull/302?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/qpid-proton/pull/302?src=pr&el=footer).
Last update
[5d3473d...3a23b4e](https://codecov.io/gh/apache/qpid-proton/pull/302?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Build failure with -DPROACTOR=none
> ----------------------------------
>
> Key: PROTON-2355
> URL: https://issues.apache.org/jira/browse/PROTON-2355
> Project: Qpid Proton
> Issue Type: Bug
> Components: build
> Affects Versions: proton-c-0.33.0
> Reporter: Fabrice Fontaine
> Priority: Major
> Fix For: proton-c-0.34.0
>
> Attachments: 0001-Fix-build-with-DPROACTOR-none.patch
>
>
> Building with -DPROACTOR=none fails on:
> {code:java}
> CMake Error at c/CMakeLists.txt:481 (add_library):
> Error evaluating generator expression:
> $<TARGET_OBJECTS:qpid-proton-proactor-objects>
> Objects of target "qpid-proton-proactor-objects" referenced but no such
> target exists.
> {code}
> It should also be noted that libqpid-proton-cpp also assumes that a proactor
> is always available (e.g. pn_connection_wake is unconditionally used in
> ./cpp/src/connection.cpp).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
