jiridanek commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r611927885



##########
File path: cpp/src/delivery.cpp
##########
@@ -40,6 +42,7 @@ namespace proton {
 
 delivery::delivery(pn_delivery_t* d): transfer(make_wrapper(d)) {}
 receiver delivery::receiver() const { return make_wrapper<class 
receiver>(pn_delivery_link(pn_object())); }
+tag delivery::tag() const { return make_wrapper<class 
tag>(pn_delivery_tag(pn_object())); }

Review comment:
       Yeah, that's the one I saw too. 
   
   ```
   cannot convert ‘proton::internal::wrapped<proton::tag>::type’ {aka 
‘pn_bytes_t’} to ‘proton::internal::wrapped<proton::tag>::type*’ {aka 
‘pn_bytes_t*’}
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to