gemmellr commented on a change in pull request #309:
URL: https://github.com/apache/qpid-proton/pull/309#discussion_r613149341
##########
File path: cpp/src/delivery.cpp
##########
@@ -40,6 +42,7 @@ namespace proton {
delivery::delivery(pn_delivery_t* d): transfer(make_wrapper(d)) {}
receiver delivery::receiver() const { return make_wrapper<class
receiver>(pn_delivery_link(pn_object())); }
+tag delivery::tag() const { return make_wrapper<class
tag>(pn_delivery_tag(pn_object())); }
Review comment:
I would think it would be fine for a binding to generate one by default,
with then perhaps a separate ability to set it yourself if you wanted (many
probably wont need to).
The set of tags needs to be unique for deliveries considered unsettled by
either end of a given link. You can reuse tags from previously settled
deliveries if you like. Different links can use the same tags at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
