astitcher commented on a change in pull request #303:
URL: https://github.com/apache/qpid-proton/pull/303#discussion_r612835051
##########
File path: cpp/src/url.cpp
##########
@@ -274,14 +274,10 @@ std::string to_string(const url& u) {
std::istream& operator>>(std::istream& i, url& u) {
std::string s;
i >> s;
- if (!i.fail() && !i.bad()) {
- if (!s.empty()) {
- url::impl* p = new url::impl(s);
- p->defaults();
- u.impl_.reset(p);
- } else {
- i.clear(std::ios::failbit);
- }
+ if (!i.fail()) {
Review comment:
I think that the premise that you can't get s.empty by itself might be
wrong - it looks to me that getting end-of-file is independent from fail and
bad so I think it should be possible to eof and s.empty() but !fail && !bad.
However I'm not any expert on iostreams either and that's just my reading of a
manpage or two.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
