astitcher commented on a change in pull request #303:
URL: https://github.com/apache/qpid-proton/pull/303#discussion_r613209137
##########
File path: cpp/src/url.cpp
##########
@@ -274,14 +274,10 @@ std::string to_string(const url& u) {
std::istream& operator>>(std::istream& i, url& u) {
std::string s;
i >> s;
- if (!i.fail() && !i.bad()) {
- if (!s.empty()) {
- url::impl* p = new url::impl(s);
- p->defaults();
- u.impl_.reset(p);
- } else {
- i.clear(std::ios::failbit);
- }
+ if (!i.fail()) {
Review comment:
@DreamPearl you've convinced me! Thanks for the thorough work.
I also prefer the ```i.fail()``` version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
