grs commented on a change in pull request #1125:
URL: https://github.com/apache/qpid-dispatch/pull/1125#discussion_r614206633
##########
File path: src/router_core/delivery.c
##########
@@ -1246,6 +1247,8 @@ qd_delivery_state_t
*qdr_delivery_take_local_delivery_state(qdr_delivery_t *dlv,
//
void qdr_delivery_move_delivery_state_CT(qdr_delivery_t *dlv, qdr_delivery_t
*peer)
{
+ /// kag: crap, this may be an issue: possible drop of seq updates!
+
Review comment:
For TCP_SEQ_ACK (or indeed PN_RECEIVED) it is just a sequence number (or
two) to be updated. Perhaps we could update that in place?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
