grs commented on a change in pull request #1125:
URL: https://github.com/apache/qpid-dispatch/pull/1125#discussion_r614208317
##########
File path: src/adaptors/tcp_adaptor.c
##########
@@ -34,6 +34,11 @@
#include <inttypes.h>
#include <stdio.h>
+const uint32_t TCP_MAX_CAPACITY = 131072;
+const uint64_t TCP_SEQ_ACK = 999; // TBD
Review comment:
PN_RECEIVED is very similar to this new type, but has two sequences (we
could ignore one or the other in the case of TCP should we wish).
One minor upside of using that is that the protocol trace logging in proton
already includes the state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
