ChugR commented on a change in pull request #1129: URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r615055634
########## File path: src/adaptors/tcp_adaptor.c ########## @@ -782,6 +965,14 @@ static void qdr_tcp_open_server_side_connection(qdr_tcp_connection_t* tc) // This attach passes the ownership of the delivery from the core-side connection and link // to the adaptor-side outgoing connection and link. + uint64_t i_conn_id = 0; + uint64_t i_link_id = 0; + uint64_t i_dlv_id = 0; + if (!!tc->initial_delivery) { + i_conn_id = tc->initial_delivery->conn_id; Review comment: qdr_link_first_attach conditionally "adjusts" the delivery's identity. This code is conditionally memorizing what the initial delivery had before the adjustment. The log statement giving identical [Cx]{Lx][Dx] values before and after was pretty lame. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org