grs commented on a change in pull request #1129:
URL: https://github.com/apache/qpid-dispatch/pull/1129#discussion_r615069069
##########
File path: src/adaptors/tcp_adaptor.c
##########
@@ -57,11 +57,15 @@ struct qdr_tcp_connection_t {
qdr_delivery_t *outstream;
bool ingress;
bool flow_enabled;
+ bool incoming_started;
bool egress_dispatcher;
bool connector_closed;//only used if
egress_dispatcher=true
bool in_list; // This connection is in the
adaptor's connections list
- bool raw_closed_read;
- bool raw_closed_write;
+ bool raw_closed_read; // proton event seen
+ bool raw_closed_write; // proton event seen or
write_close called
+ bool raw_read_shutdown; // stream closed
+ bool read_eos_seen;
+ qd_buffer_list_t early_raw_read_bufs; // read from raw conn before
ingress stream ready
Review comment:
I don't believe we would need a wake as we would be creating the
instream on the io thread anyway. All that is needed is to drain the data
available and append it to the instream.
We can't get a READ event if we don't grant any buffers anyway. Presumably
the READ_CLOSED event must come after we have read all the data, else how would
we know there was no more left. @astitcher ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
