ganeshmurthy commented on a change in pull request #1176:
URL: https://github.com/apache/qpid-dispatch/pull/1176#discussion_r623113540
##########
File path: src/server.c
##########
@@ -1155,56 +1156,55 @@ static qd_failover_item_t
*qd_connector_get_conn_info(qd_connector_t *ct) {
/* Timer callback to try/retry connection open */
-static void try_open_lh(qd_connector_t *ct)
+static void try_open_lh(qd_connector_t *connector)
{
- if (ct->state != CXTR_STATE_CONNECTING && ct->state != CXTR_STATE_INIT) {
- /* No longer referenced by pn_connection or timer */
- qd_connector_decref(ct);
+ // Allocate a new connection. No other thread will touch this
+ // connection until pn_proactor_connect is called below
+ qd_connection_t *qd_conn = qd_server_connection(connector->server,
&connector->config);
+ if (!qd_conn) { /* Try again later */
+ qd_log(connector->server->log_source, QD_LOG_CRITICAL, "Allocation
failure connecting to %s",
+ connector->config.host_port);
+ connector->delay = 10000;
+ connector->state = CXTR_STATE_CONNECTING;
Review comment:
Logically speaking, should the state here be CXTR_STATE_FAILED ? After
all the qd_server_connection() failed to allocate a new qd_connection_t object.
When the next timer fires after 10 seconds, it will set the state to
CXTR_STATE_CONNECTING, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
