ganeshmurthy commented on a change in pull request #1176:
URL: https://github.com/apache/qpid-dispatch/pull/1176#discussion_r623130386
##########
File path: src/connection_manager.c
##########
@@ -790,6 +790,8 @@ qd_error_t qd_entity_refresh_connector(qd_entity_t* entity,
void *impl)
int i = 1;
int num_items = 0;
+ sys_mutex_lock(ct->lock);
+
Review comment:
If the connector state is CXTR_STATE_DELETED, should we just return
immediately? Why loop thru the conn_info_list and so on? When the user runs a
qdmanage QUERY --type=connector, I think the deleted connector
(CXTR_STATE_DELETED) should not even show up in the list of connectors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
