jiridanek commented on a change in pull request #1197:
URL: https://github.com/apache/qpid-dispatch/pull/1197#discussion_r628463490
##########
File path: tests/system_test.py
##########
@@ -1107,15 +1107,10 @@ def on_accepted(self, event):
event.delivery.settle()
def on_released(self, event):
- # for some reason Proton 'helpfully' calls on_released even though the
- # delivery state is actually MODIFIED
if event.delivery.remote_state == Delivery.MODIFIED:
- return self.on_modified(event)
Review comment:
This makes the handlers work the way they "should've been" done in
Proton, imo. I thought that it was a reasonable improved thing to do. But ok,
the Proton orthodoxy prevails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
