jiridanek commented on a change in pull request #312:
URL: https://github.com/apache/qpid-proton/pull/312#discussion_r632670303
##########
File path: c/CMakeLists.txt
##########
@@ -487,16 +492,18 @@ if (BUILD_STATIC_LIBS)
target_compile_definitions(qpid-proton-static PUBLIC PROTON_DECLARE_STATIC)
target_link_libraries (qpid-proton-static
qpid-proton-core-static
- $<$<BOOL:${HAS_PROACTOR}>:qpid-proton-proactor-static>
+ ${TARTET_qpid-proton-proactor-static}
Review comment:
The generator expression bubbled through the ProtonTargets.cmake file
(list of libraries to link to) but it was malformed there. I don't exactly
remember how and i did not try to solve it. Since the patch is now being
seriously considered (something beyond my immediate hopes yesterday), I will
revisit this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
