jiridanek commented on a change in pull request #312:
URL: https://github.com/apache/qpid-proton/pull/312#discussion_r632672479
##########
File path: c/CMakeLists.txt
##########
@@ -487,16 +492,18 @@ if (BUILD_STATIC_LIBS)
target_compile_definitions(qpid-proton-static PUBLIC PROTON_DECLARE_STATIC)
target_link_libraries (qpid-proton-static
qpid-proton-core-static
- $<$<BOOL:${HAS_PROACTOR}>:qpid-proton-proactor-static>
+ ${TARTET_qpid-proton-proactor-static}
${SSL_LIB} ${SASL_LIB} ${TIME_LIB} ${PLATFORM_LIBS} ${PROACTOR_LIBS})
+ set_target_properties(qpid-proton-static PROPERTIES
+ POSITION_INDEPENDENT_CODE ON)
endif(BUILD_STATIC_LIBS)
# Install executables and libraries
if (BUILD_STATIC_LIBS)
set(STATIC_LIBS qpid-proton-static qpid-proton-core-static)
endif()
install(TARGETS qpid-proton qpid-proton-core ${STATIC_LIBS}
- EXPORT proton
+ EXPORT ProtonTargets
Review comment:
It causes CMake to generate ProtonTargets.cmake, which I then include
from the ProtonConfig.cmake file. It does the heavy lifting of locating the
library files relative to the ProtonConfig.cmake. I'll attach that file
[ProtonTargets.txt](https://github.com/apache/qpid-proton/files/6480182/ProtonTargets.txt)
[ProtonTargets-relwithdebinfo.txt](https://github.com/apache/qpid-proton/files/6480183/ProtonTargets-relwithdebinfo.txt)
[ProtonConfig.txt](https://github.com/apache/qpid-proton/files/6480184/ProtonConfig.txt)
[ProtonConfigVersion.txt](https://github.com/apache/qpid-proton/files/6480185/ProtonConfigVersion.txt)
[FindCyrusSASL.txt](https://github.com/apache/qpid-proton/files/6480186/FindCyrusSASL.txt)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
