gemmellr commented on a change in pull request #319:
URL: https://github.com/apache/qpid-proton/pull/319#discussion_r649123222
##########
File path: .github/workflows/build.yml
##########
@@ -60,6 +63,28 @@ jobs:
if: runner.os == 'macOS'
run: |
brew install libuv swig pkgconfig jsoncpp
+ - uses: actions/checkout@v2
+ - name: Create directory for opentelemetry-cpp
+ run: mkdir -p "${OTelDir}"
+ shell: bash
+ - name: Checkout opentelemetry-cpp repo
+ uses: actions/checkout@v2
+ with:
+ repository: open-telemetry/opentelemetry-cpp
+ path: ${{env.OTelDir}}
+ - uses: actions/checkout@v2
Review comment:
This looks redundant, duplicating the original proton checkout, with
cleanup side effects.
##########
File path: .github/workflows/build.yml
##########
@@ -60,6 +63,28 @@ jobs:
if: runner.os == 'macOS'
run: |
brew install libuv swig pkgconfig jsoncpp
+ - uses: actions/checkout@v2
Review comment:
This looks redundant, duplicating the original proton checkout, with
cleanup side effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
