gemmellr commented on a change in pull request #319:
URL: https://github.com/apache/qpid-proton/pull/319#discussion_r650848950
##########
File path: cpp/CMakeLists.txt
##########
@@ -37,7 +37,7 @@ else()
endif()
# Check for OPENTELEMETRY-CPP for distributed tracing
-find_package(opentelemetry-cpp)
+find_package(opentelemetry-cpp CONFIG REQUIRED)
Review comment:
I would doubt it generally, but especially since its not yet even in a
released state. I had suggested on IRC shortly before your comment the next
step would be to make it optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
