Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/217#discussion_r108065662
--- Diff: catalog/tests/PartitionScheme_unittest.cpp ---
@@ -611,6 +665,7 @@ TEST(PartitionSchemeTest,
CheckRangePartitionSchemeSerialization) {
EXPECT_EQ(blocks_in_part_scheme, blocks_in_part_scheme_from_proto);
}
}
+*/
--- End diff --
Let's not check in commented code. We can either get rid of these tests or
try to fix it. I am not sure what these tests are trying to verify. If the
functionality being tested is not really critical, we can remove the commented
code, create a JIRA issue and move on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
