Github user hbdeshmukh commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/217#discussion_r107975788
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -724,6 +708,25 @@ const S::PartitionSchemeHeader*
Resolver::resolvePartitionClause(
THROW_SQL_ERROR_AT(partition_type_string) << "Unrecognized partition
type: " << partition_type;
}
+
proto->set_num_partitions(partition_clause->num_partitions()->long_value());
--- End diff --
Do we perform error checks for the following conditions?
1. Number of partitions = 0
2. No attribute specified in the partitioning attributes' list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
