Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/217#discussion_r107982736
--- Diff: storage/InsertDestination.cpp ---
@@ -682,8 +685,11 @@ void
PartitionAwareInsertDestination::bulkInsertTuplesWithRemappedAttributes(
// set a bit in the appropriate TupleIdSequence.
accessor->beginIteration();
while (accessor->next()) {
- TypedValue attr_val =
accessor->getTypedValue(attribute_map[partition_attribute_id]);
-
partition_membership[partition_scheme_header_->getPartitionId(attr_val)]
+ PartitionSchemeHeader::PartitionValues values;
+ for (const attribute_id attr_id :
partition_scheme_header_->getPartitionAttributeIds()) {
+ values.push_back(accessor->getTypedValue(attr_id));
+ }
--- End diff --
I just checked the methods you mentioned, but I don't think we could use
them, as we also need to get partition id in a range partition.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
