----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56036/#review163393 -----------------------------------------------------------
security-admin/contrib/solr_for_audit_setup/setup.sh (line 291) <https://reviews.apache.org/r/56036/#comment234828> If SOLR_VERSION is *not* set, then this condition will always return true - Don Bosco Durai On Jan. 27, 2017, 7:40 p.m., Paul Otto wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56036/ > ----------------------------------------------------------- > > (Updated Jan. 27, 2017, 7:40 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1335 > https://issues.apache.org/jira/browse/RANGER-1335 > > > Repository: ranger > > > Description > ------- > > Add support for Solr 5.5 and above. Changes allow core to load without error. > User sets the SOLR_VERSION config in install.properties and setup.sh will > update the luceneMatchVersion and either leave in AdminHandlers if < 5.5 > otherwise comment out. > > > Diffs > ----- > > security-admin/contrib/solr_for_audit_setup/conf/solrconfig.xml > 3347f1b7b45158381b59ae2fec14fe0e10b8ba76 > security-admin/contrib/solr_for_audit_setup/conf/solrconfig.xml.j2 > 4e6df8aeb3a0895bce4f83f3db2d9611b850f2f3 > security-admin/contrib/solr_for_audit_setup/install.properties > f5d8cef960586ac6381d54a89454c0c774893c6e > security-admin/contrib/solr_for_audit_setup/setup.sh > c4a8817700a71235e3894fd0cfa425a9de1bbec6 > > Diff: https://reviews.apache.org/r/56036/diff/ > > > Testing > ------- > > Manual testing done against multiple versions of Solr, using Chef Kitchen to > assist. > > > Thanks, > > Paul Otto > >
