> On Jan. 28, 2017, 7:15 a.m., Don Bosco Durai wrote: > > security-admin/contrib/solr_for_audit_setup/setup.sh, line 292 > > <https://reviews.apache.org/r/56036/diff/1/?file=1617938#file1617938line292> > > > > If SOLR_VERSION is *not* set, then this condition will always return > > true
This is resolved by the removal of that new property. - Paul ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56036/#review163393 ----------------------------------------------------------- On Jan. 29, 2017, 3:33 p.m., Paul Otto wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56036/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2017, 3:33 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1335 > https://issues.apache.org/jira/browse/RANGER-1335 > > > Repository: ranger > > > Description > ------- > > Remove AdminHandler block from solrconfig.xml as its presence breaks Solr 5.5 > and above. Ranger currently only supports Solr 5.2 and above, all of which > work without this block (was deprecated in versions >= 5.0 and < 5.5. > > > Diffs > ----- > > security-admin/contrib/solr_for_audit_setup/conf/solrconfig.xml > 3347f1b7b45158381b59ae2fec14fe0e10b8ba76 > security-admin/contrib/solr_for_audit_setup/conf/solrconfig.xml.j2 > 4e6df8aeb3a0895bce4f83f3db2d9611b850f2f3 > > Diff: https://reviews.apache.org/r/56036/diff/ > > > Testing > ------- > > Manual testing done against multiple versions of Solr, using Chef Kitchen to > assist. > > > Thanks, > > Paul Otto > >
