> On Feb. 7, 2017, 10:04 a.m., Colm O hEigeartaigh wrote: > > The same problem exists in the setup.py for tagsync, perhaps you could fix > > that as well as part of this patch? > > Qiang Zhang wrote: > ok,i will do it!
I rebuilt the patch, which includes setup.py for the Ranger UserSync and tagsync. - Qiang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56372/#review164485 ----------------------------------------------------------- On Feb. 7, 2017, 11:58 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56372/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 11:58 a.m.) > > > Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, > Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1356 > https://issues.apache.org/jira/browse/RANGER-1356 > > > Repository: ranger > > > Description > ------- > > The installer does not filter comments lines for the configuration file when > installing the Ranger UserSync Process. > Command line starting with ’#‘ have not been filtered out during parsing the > configuration file to get configurating value. If we use '#' to comment a > line and it includes '=', the comment will not work. On the left of the '=', > it will be parsed as a key and the right will be parsed as a value. As a > result, there are as follows problems: > 1. There are invalid attribute values. > 2. Invalid parsing will degrade the performance of program. > > > Diffs > ----- > > unixauthservice/scripts/setup.py dc383af > > Diff: https://reviews.apache.org/r/56372/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > The same problem exists in the setup.py for tagsync > > https://reviews.apache.org/media/uploaded/files/2017/02/07/43ccc1fd-538a-4aa3-b4a4-967b882c2be4__0001-RANGER-1356-The-installer-for-tagssyn.patch > > > Thanks, > > Qiang Zhang > >
