----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56372/#review164655 -----------------------------------------------------------
Ship it! Ship It! - Colm O hEigeartaigh On Feb. 7, 2017, 1:37 p.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56372/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 1:37 p.m.) > > > Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Ramesh Mani, > Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1356 > https://issues.apache.org/jira/browse/RANGER-1356 > > > Repository: ranger > > > Description > ------- > > The installer does not filter comments lines for the configuration file when > installing the Ranger UserSync Process and tagsync. > Command line starting with ’#‘ have not been filtered out during parsing the > configuration file to get configurating value. If we use '#' to comment a > line and it includes '=', the comment will not work. On the left of the '=', > it will be parsed as a key and the right will be parsed as a value. As a > result, there are as follows problems: > 1. There are invalid attribute values. > 2. Invalid parsing will degrade the performance of program. > > > Diffs > ----- > > tagsync/scripts/setup.py 29369f7 > unixauthservice/scripts/setup.py dc383af > > Diff: https://reviews.apache.org/r/56372/diff/ > > > Testing > ------- > > > Thanks, > > Qiang Zhang > >
