> On 二月 15, 2017, 10:53 a.m., Colm O hEigeartaigh wrote: > > Thanks for the patch! Could you strip out the indentation changes as it's > > difficult to see what the changes are in some of the files (e.g. are there > > changes in RangerServiceAtlas.java)?
Hi, thanks for review . Because this is the development of new functions, reuse part testconnection function code, so the code change is more, reuse some code and reconstruction so modify the methods and properties. 2.1.RangerServiceAtlas.java 1).Formatted code,Remove the TAB key is invalid 2).alter " ret = AtlasResourceMgr.getAtlasTermResources(serviceName,configs,context);" to "ret = AtlasResourceMgr.getAtlasResources(serviceName, configs,context);" 2.AtlasClient.java 1) Increasing access to the resource of the atlas API url 2) In many places alter Alter the term attribute to the resource----because term is one of the types of resouce .Resource contains(TERM,TYPE,ENTITY,TAXONOMY,OPERATION) 3).alter "getTermList( String termNameMatching, List<String> existingTermList)" to "getResourceList(final String resourceNameMatching,final String atlasResourceParamter,final List<String> existingResourceList)" ----According to the type selection method of access to resources 4).add alter connectionTestResource(final String resourceNameMatching,final String atlasResourceParamter,List<String> existingResourceList)------Testconnection function method getTypeResource(final String resourceNameMatching,final String atlasResourceParamter,List<String> existingResourceList)-----Access to type resources 5).add public List<String> getEntityResource(final String resourceNameMatching,final String atlasResourceParamter,List<String> existingResourceList)-----Access to Entity resources 6).add getTermResource(final String resourceNameMatching,final String atlasResourceParamter,List<String> existingResourceList)-----Access to Term resources 7).add getTaxonomyResource(final String resourceNameMatching,final String atlasResourceParamter,List<String> existingResourceList)----Access to Taxonomy resources 8).add getOperationResource(final String resourceNameMatching,final String atlasResourceParamter,List<String> existingResourceList)----Access to Operation resources 3.AtlasResourceMgr.java 1).alter "getAtlasTermResources(String serviceName, Map<String, String> configs,ResourceLookupContext context)" to "getAtlasResources(String serviceName, Map<String, String> configs,ResourceLookupContext context)" ----because term is one of the types of resouce .Resource contains(TERM,TYPE,ENTITY,TAXONOMY,OPERATION) . and alter "atlasTermList" to "atlasResourceList" 2). alter "public static List<String> getAtlasTermResource(String serviceName, Map<String, String> configs, String atlasTermName, List<String> atlasTermList)" to "getAtlasResource(String serviceName, Map<String, String> configs, String atlasResourceName, String atlasResourceParamter,List<String> atlasResourceList)" ----because term is one of the types of resouce .Resource contains(TERM,TYPE,ENTITY,TAXONOMY,OPERATION) 4.ResourceEntityResponse.java add ResourceEntityResponse class for Convert json string to object(EntityResource) 5.ResourceOperationResponse.java add ResourceOperationResponse class for Convert json string to object(OperationResource) 6.ResourceTaxonomyResponse.java add ResourceTaxonomyResponse class for Convert json string to object(TaxonomyResource) 7.ResourceTermResponse.java add ResourceTermResponse class for Convert json string to object(TermResource) 8.ResourceTypeResponse.java add ResourceTypeResponse class for Convert json string to object(TypeResource) - Qiang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56654/#review165680 ----------------------------------------------------------- On 二月 14, 2017, 11:23 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56654/ > ----------------------------------------------------------- > > (Updated 二月 14, 2017, 11:23 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh, > Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1348 > https://issues.apache.org/jira/browse/RANGER-1348 > > > Repository: ranger > > > Description > ------- > > Autocompletion not working properly Resource Autocompletion fuction I have > submit the patch please review it. > > > Diffs > ----- > > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java > ba4d263 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java > 4f90469 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasConnectionMgr.java > 84e24c5 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java > 93b2662 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceEntityResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceOperationResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTaxonomyResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTermResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTypeResponse.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/56654/diff/ > > > Testing > ------- > > Tested it > > > Thanks, > > Qiang Zhang > >
