----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56654/#review165925 -----------------------------------------------------------
Thanks for making the changes! There are still some more changes I'd like to see however: a) AtlasResourceMgr: There are no spaces around "=" here: "atlasResourceName=context.getResourceName();" b) AtlasResourceMgr: Change "atlasResourceParamter" to "atlasResourceParameter c) AtlasResourceMgr: There is an indentation problem in getAtlasResource() d) Are the changes to RangerAtlasAuthorizer + RangerAtlasResource required? We should limit whitespace fixing just to classes that are being changed as part of the commit. e) AtlasClient: Missing space after = "this.statusUrl =atlasUrl + ATLAS_STATUS_API_ENDPOINT;" f) AtlasClient: Change this to 'username': LOG.error("No value found for configuration 'usename'. g) AtlasClient: Indentation wrong on line 315 "return lret;" h) AtlasClient: Indentation wrong in the try block: lines 121 -> 135 i) AtlasClient: getStatusResponse() method should be private - Colm O hEigeartaigh On Feb. 17, 2017, 4:58 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56654/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2017, 4:58 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh, > Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1348 > https://issues.apache.org/jira/browse/RANGER-1348 > > > Repository: ranger > > > Description > ------- > > Autocompletion not working properly Resource Autocompletion fuction I have > submit the patch please review it. > > > Diffs > ----- > > > plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasAuthorizer.java > 2038645 > > plugin-atlas/src/main/java/org/apache/ranger/authorization/atlas/authorizer/RangerAtlasResource.java > f056f3e > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java > ba4d263 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java > 4f90469 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasConnectionMgr.java > 84e24c5 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java > 93b2662 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceEntityResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceOperationResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTaxonomyResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTermResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTypeResponse.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/56654/diff/ > > > Testing > ------- > > Tested it > > > Thanks, > > Qiang Zhang > >