> On 二月 20, 2017, 9:46 a.m., Colm O hEigeartaigh wrote: > > Thanks for making the changes. Could you update the patch to the latest > > master, it doesn't apply as there was a change to AtlasClient. The other > > change I'd like to see is that there is still a "atlasResourceParamter" > > (instead of atlasResourceParameter) in AtlasResourceMgr. > > Colm O hEigeartaigh wrote: > *bump* Please address my last comment and I'll review again with a view > to merging the fix.
Ok. I will update the patch after carefully tested and verified. Thanks! - Qiang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56654/#review166073 ----------------------------------------------------------- On 二月 18, 2017, 6:44 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56654/ > ----------------------------------------------------------- > > (Updated 二月 18, 2017, 6:44 a.m.) > > > Review request for ranger, Alok Lal, Don Bosco Durai, Colm O hEigeartaigh, > Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1348 > https://issues.apache.org/jira/browse/RANGER-1348 > > > Repository: ranger > > > Description > ------- > > Autocompletion not working properly Resource Autocompletion fuction I have > submit the patch please review it. > > > Diffs > ----- > > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java > ba4d263 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasClient.java > 4f90469 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasConnectionMgr.java > 84e24c5 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/client/AtlasResourceMgr.java > 93b2662 > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceEntityResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceOperationResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTaxonomyResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTermResponse.java > PRE-CREATION > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/json/model/ResourceTypeResponse.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/56654/diff/ > > > Testing > ------- > > Tested it > > > Thanks, > > Qiang Zhang > >
