----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57988/#review170435 -----------------------------------------------------------
With this patch there are some pmd violations. Please verify and re-submit the patch. [INFO] PMD Failure: org/apache/ranger/authorization/hadoop/config/RangerConfiguration.java:23 Rule:UnusedImports Priority:4 Avoid unused imports such as 'java.io.File'. [INFO] PMD Failure: org/apache/ranger/authorization/hadoop/config/RangerConfiguration.java:24 Rule:UnusedImports Priority:4 Avoid unused imports such as 'java.net.MalformedURLException'. - Ramesh Mani On March 29, 2017, 3:34 p.m., Zsombor Gegesy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57988/ > ----------------------------------------------------------- > > (Updated March 29, 2017, 3:34 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1479 > https://issues.apache.org/jira/browse/RANGER-1479 > > > Repository: ranger > > > Description > ------- > > RangerConfiguration first checks, if the necessary xml files are on the > classpath, and after it tries to convert it to a file path, check that file > is on the filesystem, and convert that path to back to URL. If the > configurations are inside a jar, then this will fail very badly (the resource > url will be something file://config.jar!/ranger-services.xml ) > > If the conversion is removed, it would work pretty nicely > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerConfiguration.java > d81f6b9 > > > Diff: https://reviews.apache.org/r/57988/diff/2/ > > > Testing > ------- > > > Thanks, > > Zsombor Gegesy > >
