The current patch is fine. The original patch did not have author information at the top and looked like it was created with "git diff".
Colm. On Fri, Mar 31, 2017 at 12:24 PM, Zsombor <[email protected]> wrote: > On Fri, Mar 31, 2017 at 1:16 PM, Colm O hEigeartaigh <[email protected]> > wrote: > > > This is an automatically generated e-mail. To reply, visit: > > https://reviews.apache.org/r/57988/ > > > > On March 29th, 2017, 4 p.m. UTC, *Colm O hEigeartaigh* wrote: > > > > Still the same problem....please see https://cwiki.apache.org/ > confluence/pages/viewpage.action?pageId=55151244 > > > > On March 31st, 2017, 10:56 a.m. UTC, *Zsombor Gegesy* wrote: > > > > Strange, I could run git apply on the downloaded patch file on the > latest apache/master branch > > > > Yes I can apply it with "git apply" alright. However, if you create the > patch with "git format-patch" then a record is preserved of you as the > author of the commit when I apply it with "git am". > > > > > > > I do execute git format-patch HEAD~1, maybe I'm using a crippled git from > homebrew ? It says, that it is "git version 2.9.3 (Apple Git-75)" > > The other commits are seems to be fine : > https://github.com/apache/ranger/commit/5cab3e2be54a2660148c31432ea0a8 > 6764020d67 > Or have you had to alter them manually ? > > Thanks, > Zsombor > > > > > > - Colm > > > > On March 31st, 2017, 10:56 a.m. UTC, Zsombor Gegesy wrote: > > Review request for ranger. > > By Zsombor Gegesy. > > > > *Updated March 31, 2017, 10:56 a.m.* > > *Bugs: * RANGER-1479 <https://issues.apache.org/jira/browse/RANGER-1479> > > *Repository: * ranger > > Description > > > > RangerConfiguration first checks, if the necessary xml files are on the > classpath, and after it tries to convert it to a file path, check that file > is on the filesystem, and convert that path to back to URL. If the > configurations are inside a jar, then this will fail very badly (the > resource url will be something file://config.jar!/ranger-services.xml ) > > > > If the conversion is removed, it would work pretty nicely > > > > Diffs > > > > - agents-common/src/main/java/org/apache/ranger/ > > authorization/hadoop/config/RangerConfiguration.java (d81f6b9) > > > > View Diff <https://reviews.apache.org/r/57988/diff/3/> > > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com
