----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57988/#review170704 -----------------------------------------------------------
I think the error message should be changed. "Unable to find URL for the resource name..." is not accurate as we know the URL is not null at this point. Maybe something like "Unable to load the resource name...". No harm in logging the stacktrace at debug level as well. - Colm O hEigeartaigh On March 31, 2017, 10:56 a.m., Zsombor Gegesy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57988/ > ----------------------------------------------------------- > > (Updated March 31, 2017, 10:56 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-1479 > https://issues.apache.org/jira/browse/RANGER-1479 > > > Repository: ranger > > > Description > ------- > > RangerConfiguration first checks, if the necessary xml files are on the > classpath, and after it tries to convert it to a file path, check that file > is on the filesystem, and convert that path to back to URL. If the > configurations are inside a jar, then this will fail very badly (the resource > url will be something file://config.jar!/ranger-services.xml ) > > If the conversion is removed, it would work pretty nicely > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerConfiguration.java > d81f6b9 > > > Diff: https://reviews.apache.org/r/57988/diff/3/ > > > Testing > ------- > > > Thanks, > > Zsombor Gegesy > >
