----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58184/#review171084 -----------------------------------------------------------
security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java Lines 110 (patched) <https://reviews.apache.org/r/58184/#comment243942> All the below Mock injection is not used in the code. vXAsset searchFilter xAssetService xResourceService xCredentialStoreService request servicePolicies xTrxLogService xPolicyExportAudits xAccessAuditService xxServiceDefDao restErrorUtil security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java Lines 133 (patched) <https://reviews.apache.org/r/58184/#comment243946> remove whitespaces security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java Lines 355 (patched) <https://reviews.apache.org/r/58184/#comment243944> Use the already defined Mock @Mock HttpServletRequest request; Similarly check for other Mock objects as well. - Ayub Pathan On April 4, 2017, 7:57 p.m., deepak sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58184/ > ----------------------------------------------------------- > > (Updated April 4, 2017, 7:57 p.m.) > > > Review request for ranger, Ankita Sinha and Mehul Parikh. > > > Bugs: RANGER-1497 > https://issues.apache.org/jira/browse/RANGER-1497 > > > Repository: ranger > > > Description > ------- > > [RANGER-1497]Improvement of unit test coverage for ranger by adding the unit > tests for org.apache.ranger.rest.AssetREST > > > Diffs > ----- > > security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58184/diff/1/ > > > Testing > ------- > > tested the Junit tests added locally. > > > Thanks, > > deepak sharma > >
