----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58184/#review171156 -----------------------------------------------------------
security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java Lines 839 (patched) <https://reviews.apache.org/r/58184/#comment244040> Please check that if there is exception in serviceREST.grantAccess is it to be considered as failure, instead of doing e.printStackTrace() serviceREST.grantPermission() uses serviceREST.grantAccess() for all the grant access and if there is a failure there that means grant failed. Please check all the other occurances like this for handling the exception cases. - Ramesh Mani On April 5, 2017, 9:08 a.m., deepak sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58184/ > ----------------------------------------------------------- > > (Updated April 5, 2017, 9:08 a.m.) > > > Review request for ranger, Ankita Sinha and Mehul Parikh. > > > Bugs: RANGER-1497 > https://issues.apache.org/jira/browse/RANGER-1497 > > > Repository: ranger > > > Description > ------- > > [RANGER-1497]Improvement of unit test coverage for ranger by adding the unit > tests for org.apache.ranger.rest.AssetREST > > > Diffs > ----- > > security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58184/diff/2/ > > > Testing > ------- > > tested the Junit tests added locally. > > > Thanks, > > deepak sharma > >
