> On April 5, 2017, 4:01 a.m., Ayub Pathan wrote: > > security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java > > Lines 110 (patched) > > <https://reviews.apache.org/r/58184/diff/1/?file=1684530#file1684530line110> > > > > All the below Mock injection is not used in the code. > > > > vXAsset > > searchFilter > > xAssetService > > xResourceService > > xCredentialStoreService > > request > > servicePolicies > > xTrxLogService > > xPolicyExportAudits > > xAccessAuditService > > xxServiceDefDao > > restErrorUtil
Thanks for the review Ayub, i removed some of the unused mock injection, but following are used actually, and if you remove them then test will fail: xAssetService: https://github.com/hortonworks/ranger/blob/HDP-2.3.1.1/security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java#L255 same way below mentioned are also used: xResourceService: xCredentialStoreService: XTrxLogService: xPolicyExportAudits xAccessAuditService but rest rest of them i have removed. - deepak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58184/#review171084 ----------------------------------------------------------- On April 5, 2017, 9:08 a.m., deepak sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58184/ > ----------------------------------------------------------- > > (Updated April 5, 2017, 9:08 a.m.) > > > Review request for ranger, Ankita Sinha and Mehul Parikh. > > > Bugs: RANGER-1497 > https://issues.apache.org/jira/browse/RANGER-1497 > > > Repository: ranger > > > Description > ------- > > [RANGER-1497]Improvement of unit test coverage for ranger by adding the unit > tests for org.apache.ranger.rest.AssetREST > > > Diffs > ----- > > security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/58184/diff/2/ > > > Testing > ------- > > tested the Junit tests added locally. > > > Thanks, > > deepak sharma > >
