----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58154/#review173093 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java Lines 757 (patched) <https://reviews.apache.org/r/58154/#comment246168> lines #757 through #764 should be replaced with the following: if(ret.getIsAccessDetermined()) { if (StringUtils.equalsIgnoreCase(ret.getMaskType(), RangerPolicy.MASK_TYPE_NONE)) { ret.setMaskType(null); } if(ret.getIsAuditedDetermined()) { break; } } } agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java Lines 805 (patched) <https://reviews.apache.org/r/58154/#comment246169> lines #805 through #814 should be replaced with: if (tagEvalResult.getIsAccessDetermined()) { if (StringUtils.equalsIgnoreCase(tagEvalResult.getMaskType(), RangerPolicy.MASK_TYPE_NONE)) { tagEvalResult.setMaskType(null); } if (tagEvalResult.getIsAuditedDetermined()) { break; } } agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java Lines 871 (patched) <https://reviews.apache.org/r/58154/#comment246171> lines #871 through #877 should be replaced with: if (ret.getIsAuditedDetermined() && ret.getIsAccessDetermined() { break; } agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java Lines 918 (patched) <https://reviews.apache.org/r/58154/#comment246172> lines #918 through #928 should be replaced with: if (tagEvalResult.getIsAuditedDetermined() && tagEvalResult.getIsAccessDetermined()) { break; } - Madhan Neethiraj On April 3, 2017, 6:38 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58154/ > ----------------------------------------------------------- > > (Updated April 3, 2017, 6:38 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-1493 > https://issues.apache.org/jira/browse/RANGER-1493 > > > Repository: ranger > > > Description > ------- > > The policy engine is enhanced to support tag-based policies for masking as > well i.e. evalDataMaskPolicies() > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceImpl.java > 9d8a651 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java > 06c7d16 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > 508ef93 > > > Diff: https://reviews.apache.org/r/58154/diff/1/ > > > Testing > ------- > > Updated Tag-Service-Definition with dataMaskDef section for hive component, > created a tag policy for data-masking; tagged a hive column with a tag and > used beeline to test data-masking for that column. > > > Thanks, > > Abhay Kulkarni > >
