----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58154/#review176545 -----------------------------------------------------------
Fix it, then Ship it! agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java Lines 820 (patched) <https://reviews.apache.org/r/58154/#comment249932> This block should either be moved up, before line #815 or updated to replace 'tagEvalResult' with 'result'. - Madhan Neethiraj On April 27, 2017, 8:40 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58154/ > ----------------------------------------------------------- > > (Updated April 27, 2017, 8:40 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-1493 > https://issues.apache.org/jira/browse/RANGER-1493 > > > Repository: ranger > > > Description > ------- > > The policy engine is enhanced to support tag-based policies for masking as > well i.e. evalDataMaskPolicies() > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/PolicyEvaluatorForTag.java > PRE-CREATION > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java > 904fc86 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java > 06c7d16 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > 508ef93 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > 0793a6a > > > Diff: https://reviews.apache.org/r/58154/diff/3/ > > > Testing > ------- > > Updated Tag-Service-Definition with dataMaskDef section for hive component, > created a tag policy for data-masking; tagged a hive column with a tag and > used beeline to test data-masking for that column. > > > Thanks, > > Abhay Kulkarni > >
