-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58154/#review173170
-----------------------------------------------------------
The current patch doesn't apply to master. It's better to use
Collections.emptyMap() instead of Collections.EMPTY_MAP. You could combine
these if statements:
+ if(ret.getIsAccessDetermined()) {
+ if
(StringUtils.equalsIgnoreCase(ret.getMaskType(), RangerPolicy.MASK_TYPE_NONE)) {
+ ret.setMaskType(null);
+ }
+ }
- Colm O hEigeartaigh
On April 26, 2017, 11:14 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58154/
> -----------------------------------------------------------
>
> (Updated April 26, 2017, 11:14 p.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-1493
> https://issues.apache.org/jira/browse/RANGER-1493
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The policy engine is enhanced to support tag-based policies for masking as
> well i.e. evalDataMaskPolicies()
>
>
> Diffs
> -----
>
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/DataMaskOrRowFilterEvaluator.java
> PRE-CREATION
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResourceImpl.java
> 9d8a651
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java
> 904fc86
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngine.java
> 06c7d16
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
> 508ef93
>
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java
> 0793a6a
>
>
> Diff: https://reviews.apache.org/r/58154/diff/2/
>
>
> Testing
> -------
>
> Updated Tag-Service-Definition with dataMaskDef section for hive component,
> created a tag policy for data-masking; tagged a hive column with a tag and
> used beeline to test data-masking for that column.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
