> On May 23, 2017, 9:08 a.m., Colm O hEigeartaigh wrote: > > I'm not sure about the changed logic to be honest. If the user or group > > doesn't exist, wouldn't it be better to print an error message and abort? > > pengjianhua wrote: > Initially, I was consistent with your idea. The original developer is to > determine whether the user and the user group exist. The install file > permissions were set according to the different users and user groups. It > uses the length of the user and the user group string as the judgment logic > in original code. This is a clear error. > > If the user or group doesn't exist, can the installer print an error > message and abort? If you are also the point of view, I will submit this > issue using this logic.
I think instead it would be better that if a custom user/group are specified, but don't exist, then print out a warning message to the console (giving the user/group name that was specified) and proceed with the default values. - Colm ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59436/#review175774 ----------------------------------------------------------- On May 23, 2017, 2:13 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59436/ > ----------------------------------------------------------- > > (Updated May 23, 2017, 2:13 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1600 > https://issues.apache.org/jira/browse/RANGER-1600 > > > Repository: ranger > > > Description > ------- > > In install.properties, I configured the testusr user and the testgroup groups > that not exist in system. The error “chown: invalid user: testusr:testgroup” > occured during installed the hbase plugin. > The enable script judges whether the user and the user group are empty to > determine whether they are available. This logic is flawed. > > > Diffs > ----- > > agents-common/scripts/enable-agent.sh 76ba8f0 > > > Diff: https://reviews.apache.org/r/59436/diff/2/ > > > Testing > ------- > > > Thanks, > > pengjianhua > >
