----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61021/#review181282 -----------------------------------------------------------
agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json Lines 18 (patched) <https://reviews.apache.org/r/61021/#comment256808> Is this going to be "String" to be Matched. If so use org.apache.ranger.plugin.resourcematcher.RangerDefaultResourceMatcher. Refer ranger-servicedef-hive.json for it. plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java Lines 71 (patched) <https://reviews.apache.org/r/61021/#comment256810> Why there is a check for "Cube" first and then "Project". Is there a resource hierarchy like Project -> cubes. If so does the "Project" has to be a another resource in the resource definition? Please review this and update. Refer Hive Plugin if needed. security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java Line 2764 (original), 2769 (patched) <https://reviews.apache.org/r/61021/#comment256812> User/Group and default policy should be moved to org.apache.ranger.services.hdfs.RangerServiceKylin. You need to create one and refer it in ranger-servicedef-kylin.json. ServiceDBStore.java should have call only to createDefaultPolicy(). This class should not be changed as such. Refer HDFS/KMS plugin and getDefaultRangerPolicies for those plugin in org.apache.ranger.services.hdfs.RangerService security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java Lines 581 (patched) <https://reviews.apache.org/r/61021/#comment256815> searchKylinUsers should be done in SearchUtil.java. THis class as such cannot be changed. It is only for Service related calls. Please move this out and place it in SearchUtil. Look at other calls in XUserREST.java security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java Lines 372 (patched) <https://reviews.apache.org/r/61021/#comment256818> Repeated class kylinUserResponse. Make it part of Util class - Ramesh Mani On July 21, 2017, 7:40 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61021/ > ----------------------------------------------------------- > > (Updated July 21, 2017, 7:40 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, sam rome, and Velmurugan Periasamy. > > > Bugs: RANGER-1672 > https://issues.apache.org/jira/browse/RANGER-1672 > > > Repository: ranger > > > Description > ------- > > Ranger supports plugin to enable, monitor and manage apache kylin > > > Diffs > ----- > > agents-common/scripts/enable-agent.sh d31a264 > > agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java > 0bc09f6 > > agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java > 58cdd35 > agents-common/src/main/resources/service-defs/ranger-servicedef-kylin.json > PRE-CREATION > plugin-kylin/.gitignore PRE-CREATION > plugin-kylin/conf/ranger-kylin-audit-changes.cfg PRE-CREATION > plugin-kylin/conf/ranger-kylin-audit.xml PRE-CREATION > plugin-kylin/conf/ranger-kylin-security-changes.cfg PRE-CREATION > plugin-kylin/conf/ranger-kylin-security.xml PRE-CREATION > plugin-kylin/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION > plugin-kylin/conf/ranger-policymgr-ssl.xml PRE-CREATION > plugin-kylin/pom.xml PRE-CREATION > plugin-kylin/scripts/install.properties PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/RangerServiceKylin.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinClient.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinConnectionMgr.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/KylinResourceMgr.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinCubeResponse.java > PRE-CREATION > > plugin-kylin/src/main/java/org/apache/ranger/services/kylin/client/json/model/KylinProjectResponse.java > PRE-CREATION > pom.xml 3fcc4aa > ranger-kylin-plugin-shim/.gitignore PRE-CREATION > ranger-kylin-plugin-shim/pom.xml PRE-CREATION > > ranger-kylin-plugin-shim/src/main/java/org/apache/ranger/authorization/kylin/authorizer/RangerKylinAuthorizer.java > PRE-CREATION > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 9742265 > security-admin/src/main/java/org/apache/ranger/biz/ServiceMgr.java 722a566 > security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 6e9161e > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > af7bdfe > security-admin/src/main/webapp/scripts/views/policies/PermissionList.js > 067bf3b > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js > 6f27d5d > src/main/assembly/admin-web.xml cb1aad2 > src/main/assembly/plugin-kylin.xml PRE-CREATION > > > Diff: https://reviews.apache.org/r/61021/diff/1/ > > > Testing > ------- > > Tested > > > Thanks, > > Qiang Zhang > >
